Add-ons Mirror: Firefly discussion - Add-ons Mirror

Jump to content

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

Firefly discussion Filemanager

#1 User is offline   atg2d Icon

  • Add-ons Newbie
  • Icon
  • Group: Add-ons Developer
  • Posts: 2
  • Joined: 28-August 04

Posted 06 June 2006 - 01:18 PM

Firefly is a filemanager extension for Firefox.
It reached v 0.2. The new things are :
* Search in a folder (and subfolders)
* Keyboard shortcuts
* Keyboard navigaion
* Localization support
* External editor

Fixed the bugs mentioned here and on the Mozillazine thread.
Thanks to Philip Chee i added support for SeaMonkey.
Made it work on Linux too (at least it's working on my SuSE 10.1).
I am waiting for someone with Mac to tell me if it's working there

Created firefly.mozdev.org
For more information and contacts look there.

Attached File  firefly.xpi (136.62K)
Number of downloads: 386

This post has been edited by atg2d: 30 July 2006 - 06:52 AM

0

#2 User is offline   deathburger Icon

  • Incredibly Lazy Extension Developer
  • Icon
  • Group: Members
  • Posts: 320
  • Joined: 22-August 04
  • Location:Earth. I think.

Posted 20 June 2006 - 07:12 PM

Any chance of SeaMonkey support? I haven't looked at it yet myself.
0

#3 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 20 June 2006 - 09:09 PM

View Postdeathburger, on Jun 21 2006, 10:12, said:

Any chance of SeaMonkey support? I haven't looked at it yet myself.
You know my methods, Watson.

Anyway:

For functions and variables loaded into the window global scope, you should use names that are more likely to be unique. For example:
observerService -> firefly_observerService
observer -> firefly_observer
const XUL_FILE -> const FIREFLY_XUL_FILE
const APP_NAME = "Firefly" -> const FIREFLY_APP_NAME = "Firefly"
var dirSize; -> var FireflyDirSize;
...etc...

Phil
0

#4 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 22 June 2006 - 04:15 AM

View Postdeathburger, on Jun 21 2006, 10:12, said:

Any chance of SeaMonkey support? I haven't looked at it yet myself.
SeaMonkey Installer: Attached File  firefly_0.1_mod.xpi (78.86K)
Number of downloads: 550
Notes:
1. You will need xSidebar installed first as Firefly relies on the Firefox sidebar functionality.
2. SeaMonkey doesn't support customizable toolbars. So there is no toolbar button to start up Firefly. Opening the Firefly sidebar and clicking in it seems to start the Firefly tab.
3. There are some remaining errors in the js/error console. However since they also occur in Firefox I shall not attempt to fix these bugs.
4. Haven't tested all the functions yet.

Phil

This post has been edited by Philip Chee: 22 June 2006 - 04:16 AM

0

#5 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 22 June 2006 - 10:31 AM

Code change needed to get FireFly working in SeaMonkey. I'm pretty sure content.document also works in Firefox but I haven't tested this change in FF yet.
--- firefly\chrome\content\src\tree.original.js	Sun Jun 04 14:22:54 2006
+++ firefly\chrome\content\src\tree.js	Thu Jun 22 16:32:48 2006
@@ -111,15 +111,15 @@
 	},
 	getProgressMode : function(idx,column) {},
 	getCellValue: function(idx, column) {},
 	cycleHeader: function(col, elem) {},
 	//selectionchanged: function() {},
 	selectionchanged: function() {
 		var currentElement=this.getSelectedElement(this.selection.currentIndex);
-		var doc=selectedTabDocument().wrappedJSObject;
+		var doc=selectedTabDocument() //.wrappedJSObject;
 		
 		var addressElement=doc.getElementById('firefly_addresbox');
 		addressElement.value=currentElement[0];
 		var deckElement=doc.getElementById('containing_deck');
 		var currentSubwindow=doc.getElementById(deckElement.getAttribute('currentSubwindow'));
 		currentSubwindow.path=currentElement[0];
 		currentSubwindow.refresh();
@@ -162,15 +162,20 @@
 	},
 	getColumnProperties: function(column, element, prop) {}
 };
 function selectedTabDocument() {
 	var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
 	 	.getService(Components.interfaces.nsIWindowMediator);
 	var win = wm.getMostRecentWindow('navigator:browser');
 	var gBrowser=win.gBrowser;
-	return gBrowser.getBrowserAtIndex(gBrowser.mTabContainer.selectedIndex).contentDocument;
+	if (gBrowser.getBrowserAtIndex)
+		return gBrowser.getBrowserAtIndex(gBrowser.mTabContainer.selectedIndex).contentDocument;
+	else {
+		return content.document;
+	}
 }
 function nameSort(el1,el2) {
 	var sortDir='asc'
 	if (el1.leafName.toUpperCase()>el2.leafName.toUpperCase()) {
 		return 1;
 	} else if (el2.leafName.toUpperCase()>el1.leafName.toUpperCase()) {
 		return -1;

Phil

This post has been edited by Philip Chee: 22 June 2006 - 10:37 AM

0

#6 User is offline   deathburger Icon

  • Incredibly Lazy Extension Developer
  • Icon
  • Group: Members
  • Posts: 320
  • Joined: 22-August 04
  • Location:Earth. I think.

Posted 22 June 2006 - 12:12 PM

View PostPhilip Chee, on Jun 22 2006, 12:31, said:

Code change needed to get FireFly working in SeaMonkey

I and someone else installed it into SM, both of us saw the same thing. Firefly appeared to work as you said, but the location bar stopped working (including displaying the url), and the back & home buttons weren't working either. This was on the initial startup, the home page wasn't even loading up.

I'm on Linux, he's on XP Home SP2. Both of us installed it into the profile.

This post has been edited by deathburger: 22 June 2006 - 12:14 PM

0

#7 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 22 June 2006 - 01:40 PM

View Postdeathburger, on Jun 23 2006, 3:12, said:

I and someone else installed it into SM, both of us saw the same thing. Firefly appeared to work as you said, but the location bar stopped working (including displaying the url), and the back & home buttons weren't working either. This was on the initial startup, the home page wasn't even loading up.

For some reason the following bit of code in functs.js causes SeaMonkey to foobar. I have no idea why.
Array.prototype.inArray = function (value) {
// Returns true if the passed value is found in the
// array.  Returns false if it is not.
	var i;
	for (i=0; i < this.length; i++) {
		// Matches identical (===), not just similar (==).
		if (this[i] === value) {
			return true;
		}
	}
	return false;
}

Phil
0

#8 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 23 June 2006 - 12:44 AM

View PostPhilip Chee, on Jun 23 2006, 4:40, said:

View Postdeathburger, on Jun 23 2006, 3:12, said:

I and someone else installed it into SM, both of us saw the same thing. Firefly appeared to work as you said, but the location bar stopped working (including displaying the url), and the back & home buttons weren't working either. This was on the initial startup, the home page wasn't even loading up.
For some reason the following bit of code in functs.js causes SeaMonkey to foobar. I have no idea why.

This code triggers a bug in SeaMonkey navigator.js (and probably in other extensions as well). The workaround suggested in the mozdev project_owners mailing list didn't work. I'm waiting for other suggestions from the mailing list.

Phil
0

#9 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 23 June 2006 - 07:01 AM

Better version Attached File  firefly_0.1_mod.xpi (93.99K)
Number of downloads: 474
But still not 100% free of js-console errors. Most of which also occur in Firefox 1.5.0.4

Phil
0

#10 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 23 June 2006 - 09:55 AM

Fix more bugs: Attached File  firefly_0.1.2_mod.xpi (96.54K)
Number of downloads: 481
Note: Only tested on SeaMonkey.

Changes:
+ Fixed memory leaks in observers by using weak references.
+ Better method of accessing the top.window.
...See: Accessing elements which are ancestors of the current content window
+ Use CDATA for inline scripts in XUL files.
Previous:
+ Removed Array.prototype.inArray from functs.js
+ Rewrote filebox.xbl not to depend on Array.prototype.inArray
...See: On modifying prototypes of Javascript built-ins

Phil (Gee, is anybody paying me to do this?)

This post has been edited by Philip Chee: 23 June 2006 - 10:01 AM

0

#11 User is offline   deathburger Icon

  • Incredibly Lazy Extension Developer
  • Icon
  • Group: Members
  • Posts: 320
  • Joined: 22-August 04
  • Location:Earth. I think.

Posted 23 June 2006 - 10:56 AM

View PostPhilip Chee, on Jun 23 2006, 11:55, said:

Phil (Gee, is anybody paying me to do this?)

Not in money, but in appreciation. :) I for one have learned quite a bit from you regarding extension development. I'm sure I'm not the only one either.
0

#12 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 24 June 2006 - 09:33 PM

Fix more bugs: Attached File  firefly_0.1.3_mod.xpi (96.6K)
Number of downloads: 636
Note: Tested on SeaMonkey 1.0.2; Tested briefly on Firefox 1.5.0.4.

Changes:
+ [FIX] Selecting a different folder in the sidebar folder view doesn't refresh the view in the main Firefly tab.
I broke this when adding SeaMonkey compatibility.
I wrapped the SM specific code in an if/else block bug missed one small bit.
+ [FIX] If the currently selected tab isn't the Firefly tab, the sidebar folderview
will open a new Firefly Tab instead of reusing the existing Tab.
...See: http://kb.mozillazin...or_the_same_URL

Previously on Buffy the Vampire Slayer:
+ Fixed memory leaks in observers by using weak references.
...See: Note in nsIPrefBranchInternal.h
...See: Memory Leak in Flashblock
+ Better method of accessing the top.window.
...See: Accessing elements which are ancestors of the current content window
+ Use CDATA for inline scripts in XUL files.
+ Removed Array.prototype.inArray from functs.js
+ Rewrote filebox.xbl not to depend on Array.prototype.inArray
...See: On modifying prototypes of Javascript built-ins

Phil
0

#13 User is offline   deathburger Icon

  • Incredibly Lazy Extension Developer
  • Icon
  • Group: Members
  • Posts: 320
  • Joined: 22-August 04
  • Location:Earth. I think.

Posted 24 June 2006 - 10:40 PM

View PostPhilip Chee, on Jun 24 2006, 23:33, said:

Previously on Buffy the Vampire Slayer:

Posted Image
0

#14 User is offline   SMP_2 Icon

  • Add-ons Guru
  • Icon
  • Group: Members
  • Posts: 241
  • Joined: 20-November 05

Posted 25 June 2006 - 10:05 PM

this is cool.. :D
0

#15 User is offline   Philip Chee Icon

  • Add-ons Guru
  • Icon
  • Group: Admin
  • Posts: 382
  • Joined: 21-March 05
  • Location:Sol III (Tellus)
  • Platform: Unspecified

Posted 29 June 2006 - 12:09 AM

Attached File  firefly_0.1.4_mod.xpi (96.68K)
Number of downloads: 762
Note: Tested on SeaMonkey 1.0.2 and Firefox 1.5.0.4.

Changes:
+ Turned XPCNativeWrappers off in Firefox (FF defaults to on/SM to off) so I don't have to have seamonkey specific code in an if/else block; this also allows me to simplify some code. Also the Firefly tab is chrome code so it's not necessary to wrap it.
...See: http://developer.moz...PCNativeWrapper

Previously on Angel:
+ [FIX] Selecting a different folder in the sidebar folder view doesn't refresh the view in the main Firefly tab.
I broke this when adding SeaMonkey compatibility.
I wrapped the SM specific code in an if/else block but missed one small bit.
+ [FIX] If the currently selected tab isn't the Firefly tab, the sidebar folderview
will open a new Firefly Tab instead of reusing the existing Tab.
...See: http://kb.mozillazin...or_the_same_URL

Previously on Buffy the Vampire Slayer:
+ Fixed memory leaks in observers by using weak references.
...See: Note in nsIPrefBranchInternal.h
...See: Memory Leak in Flashblock
+ Better method of accessing the top.window.
...See: Accessing elements which are ancestors of the current content window
+ Use CDATA for inline scripts in XUL files.
+ Removed Array.prototype.inArray from functs.js
+ Rewrote filebox.xbl not to depend on Array.prototype.inArray
...See: On modifying prototypes of Javascript built-ins

Phil

This post has been edited by Philip Chee: 29 June 2006 - 12:30 AM

0

#16 User is offline   GrailKnight Icon

  • Grail Knight
  • Icon
  • Group: Members
  • Posts: 115
  • Joined: 17-June 04
  • Gender:Male
  • Location:Pennsylvania USA
  • Interests:Computers, reading, & music.
  • Platform: Vista

Posted 29 June 2006 - 08:15 AM

Very nice extension but I have a few issues.

Firefly Options have no images on toollbar

Text size in open windows is very large no button to change text size.

Can open numerous windows but no button to revert back to default.
Fx v2.0.0.2RC4, Tb v2.0a1, Fx 3.0+, Fx Portable v3.0+, & Tb Portable v3.0+
Nightly builds one and all.

Cry "Havoc", and let slip the dogs of war!
0

#17 User is offline   atg2d Icon

  • Add-ons Newbie
  • Icon
  • Group: Add-ons Developer
  • Posts: 2
  • Joined: 28-August 04

Posted 30 July 2006 - 07:56 AM

Updated the extension to v0.2
0

Page 1 of 1
  • You cannot start a new topic
  • You cannot reply to this topic

1 User(s) are reading this topic
0 members, 1 guests, 0 anonymous users